Sync OLM manifest with Readme.md && Automate future sync#85
Open
isimluk wants to merge 3 commits intoCrowdStrike:mainfrom
Open
Sync OLM manifest with Readme.md && Automate future sync#85isimluk wants to merge 3 commits intoCrowdStrike:mainfrom
isimluk wants to merge 3 commits intoCrowdStrike:mainfrom
Conversation
32ded28 to
ea68a55
Compare
Contributor
|
A recommendation here would be to do the inverse by adding a link to the Readme instead. This is what I have noticed many operators doing which is to point the manifest to either upstream documentation or their docs website through a weblink. |
Contributor
|
https://github.com/CrowdStrike/falcon-helm/blob/main/config/manifests/bases/falcon-helm.clusterserviceversion.yaml#L26 shows what I did with falcon-helm to match what others are doing. |
ea68a55 to
3a48ebe
Compare
4a685d4 to
959d0f1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.