Don't fork/exec for cat and grep to parse ifupdown2.conf#337
Open
jtru wants to merge 2 commits intoCumulusNetworks:masterfrom
Open
Don't fork/exec for cat and grep to parse ifupdown2.conf#337jtru wants to merge 2 commits intoCumulusNetworks:masterfrom
jtru wants to merge 2 commits intoCumulusNetworks:masterfrom
Conversation
This avoids gratuitous execution of POSIX utilities in a forked shell to
do a job that python itself is perfectly capable of doing.
Note that it changes existing behavior *slightly* (but for the better),
as before this patch, even a commented out line like the following:
# enable_persistent_debug_logging=yes
... in `ifupdown2.conf` would have led to the persistent debugging
feature being enabled, despite `ifupdown2.conf`'s content suggesting
that this is against the (afaict not formally specified) parsing rules.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch foregoes the use of
system()to makecatandgrepdo what's better done in pure python.I've also fixed a small typo in the
ifupdown2.conftemplate that might confuse users.