feat: Firebase link shortener with path-based URLs & reliability improvements

[davenarchives]

Description

• Implemented a robust link shortener using Firebase Realtime Database with a modern /editor/ID format.

Key Updates:

• Path-Based URLs: Replaced query parameters with a cleaner /editor/:id route for more professional sharing links.
• Smart Loading: Updated the main layout to intelligently fetch and load projects from both the user's database and the public short links database.
• Reliability: Added a prompt() fallback for clipboard copy failures and utilized Firebase's native push() for guaranteed unique IDs.
• Code Quality: Centralized filename magic strings into constants and introduced explicit TypeScript interfaces for better type safety and maintenance.

[vercel]

@davenarchives is attempting to deploy a commit to the John Lemar Gonzales' projects Team on Vercel.

A member of the Team first needs to authorize it.

[gemini-code-assist]

Summary of Changes

Hello @davenarchives, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly upgrades the project sharing capabilities by integrating a Firebase-backed link shortener. It transitions from cumbersome query parameters to clean, path-based URLs for shared projects, making links more professional and user-friendly. The changes also introduce robust project loading logic, allowing the application to seamlessly retrieve projects from both user-specific storage and public short links, alongside several reliability and code quality enhancements.

Highlights

• Firebase Shortener Integration: Implemented a new link shortener using Firebase Realtime Database, allowing projects to be shared via concise, path-based URLs (e.g., "/editor/ID").
• Enhanced Project Loading: The application's main layout now intelligently attempts to load projects first from the user's database and then falls back to checking the public short links database if a project ID isn't found.
• Improved Sharing Reliability: The sharing mechanism includes a prompt() fallback for instances where clipboard copy operations fail, and utilizes Firebase's native push() method to ensure the generation of guaranteed unique short link IDs.
• Codebase Modernization: Key filename strings have been centralized into FILE_NAMES constants for better maintainability, and explicit TypeScript interfaces (ProjectFile, ShortLinkData) have been introduced to enhance type safety.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request introduces a robust Firebase-based link shortener, a significant feature enhancement. The transition to clean, path-based URLs (/editor/:id) and reliability improvements like the clipboard fallback are well-executed. I appreciate the focus on code quality, demonstrated by centralizing magic strings into constants and defining clear TypeScript interfaces. My review includes a couple of suggestions for shortLinkService.ts to further improve data integrity and consistency with existing patterns in your codebase.

[gemini-code-assist]

Directly casting snapshot.val() with as ShortLinkData is unsafe because the data structure from the database isn't guaranteed. If the data is malformed (e.g., through manual database edits or a bug), this could lead to runtime errors. It's much safer to validate the data's structure before using it. This change also simplifies the logic by removing the else block.

    if (snapshot.exists()) {
        const data = snapshot.val();
        // Basic validation to ensure data structure is correct
        if (data && Array.isArray(data.files) && typeof data.createdAt === 'number') {
            return data as ShortLinkData;
        }
        console.error(`Invalid short link data structure for id: ${id}`);
    }
    return null;

[davenarchives]

Details: Added structural validation (Array.isArray, typeof createdAt === 'number') before casting the database snapshot to ShortLinkData.

[gemini-code-assist]

Using Date.now() relies on the client's clock, which can be inaccurate or manipulated. For consistency and reliability, it's best practice to use Firebase's serverTimestamp() to let the server assign the creation time. This also aligns with how updatedAt is handled in projectService.ts. You'll need to import serverTimestamp from firebase/database at the top of the file.

Suggested change

	createdAt: Date.now()
	createdAt: serverTimestamp()