Skip to content

MEI Encoding Column Split Fix #1327

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
DeannaLC wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

MEI Encoding Column Split Fix #1327

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions rodan-main/code/rodan/jobs/MEI_encoding/build_mei_file.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -540,7 +540,7 @@ def precompute_multi_column(
@column_split_info: The column split information from the pitch finding JSON.
"""
height = column_split_info["height"]
prev_column = 0
last_glyph = None
for glyph in glyphs:
curr_column = column_split_info["staff_to_column"][int(glyph["staff"])]
glyph["bounding_box"] = translate_bbox(
Expand All @@ -550,11 +550,11 @@ def precompute_multi_column(
curr_column,
)
glyph["column"] = curr_column
if glyph["system_begin"] and curr_column > prev_column:
glyph["column_begin"] = True
prev_column = curr_column
else:
glyph["column_begin"] = False
glyph["column_begin"] = False
if last_glyph != None:
if curr_column > last_glyph["column"]:
last_glyph["column_begin"] = True
last_glyph = glyph

# translate staves
for i, staff in enumerate(staves):
Expand Down
Loading