PAE-797: Add missing CDP Uploader status values #603
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add INITIATED to CDP_UPLOAD_STATUS and PENDING to CDP_FILE_STATUS to handle intermediate states when polling the status endpoint before scanning completes. These values are returned by CDP Uploader but were missing from our adapter's status enums.
Constants are covered by being imported and used in other tests. Testing that a constant equals itself adds no value.
|
nijk
approved these changes
Jan 8, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket: PAE-797
Summary
These intermediate states can be returned when polling the CDP Uploader
/status/{uploadId}endpoint before scanning completes. Without these values, our adapter couldn't represent all possible states.Also removed pointless tests.