Skip to content

Conversation

@myk002
Copy link
Member

@myk002 myk002 commented Dec 22, 2024

FYI: @dhthwy

Note that DF doesn't actually call this hook yet, and won't until at least 50.16/51.01-beta27

Until then, you can probably synthesize this call by tapping into dfhooks_sdl_event and rate limiting with a timer

@myk002 myk002 merged commit f095d50 into DFHack:develop Dec 23, 2024
14 checks passed
@myk002 myk002 deleted the myk_sdl_loop_hook branch December 23, 2024 00:27
@ab9rf
Copy link
Member

ab9rf commented Dec 23, 2024

we can get a better approximation by interposing renderer_2d::render, which is called from nearly the same point that the render hook is expected to be inserted

@dhthwy
Copy link
Contributor

dhthwy commented Dec 23, 2024

cool. Yeah, renderer_2d::render is already being used, and rate limiting is in place. Should be easy to switch it.

20 fps normal and 10 fps while minimized (for preview rendering), no render at all if window isn't shown (except for minimized). iirc.

Reminds me, I need to push some updates.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

No open projects
Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants