check result code when unloading a DLL #5135
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
myk002
reviewed
Dec 25, 2024
ab9rf
force-pushed
the
checked-plugin-close
branch
from
b3c7740 to
d2ab431
Compare
combine `PlugLoad-posix.cpp` and `PlugLoad-Windows.cpp` into a single file
ab9rf
force-pushed
the
checked-plugin-close
branch
from
d2ab431 to
158a0b3
Compare
Member
Author
|
i have not personally tested this on linux although the fact that it passes CI testing is a good sign |
myk002
approved these changes
Dec 25, 2024
Member
myk002
left a comment
myk002
left a comment
There was a problem hiding this comment.
wow, PlugLoad.cpp is remarkably clean now
Member
Author
i was frankly a bit surprised at how well it cleaned up with some judicious use of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #4300