Refactor core Lua state and add thread safety assertions #5159
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
split `CoreDefs.h` from `Core.h` to keep `Core` from being loaded into `RemoteClient`
ab9rf
force-pushed
the
lua-state-in-core
branch
from
37af5ff to
9483459
Compare
myk002
reviewed
Jan 1, 2025
myk002
approved these changes
Jan 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves the global Lua state from a static global in LuaTools.h to a member variable of the singleton
Core. A public accessor,getLuaState, is added toCoreto provide access. This accessor includes an assertion which guarantees that only threads that hold the core mutex attempt to acquire the core lua state. PassingtruetogetLuaStatewill bypass the assertion; this should only be used in code that is guaranteed to acquire aCoreSuspenderbefore trying to use the acquired Lua state.