[Core] output proper error messages when plugin operations fail

[myk002]

and return a proper error code

[lethosor]

FYI, removing the early return here likely also broke the behavior of -a / -all.

[myk002]

good catch. we would also benefit from an else that skips the for loop when -a is specified:

diff --git a/library/Core.cpp b/library/Core.cpp
index 2b02c46fe..6e875648f 100644
--- a/library/Core.cpp
+++ b/library/Core.cpp
@@ -818,9 +818,11 @@ command_result Core::runCommand(color_ostream &con, const std::string &first_, s
                     ret = CR_FAILURE;
                 else if (unload && !plug_mgr->unloadAll())
                     ret = CR_FAILURE;
-                else if (!plug_mgr->reloadAll())
+                else if (reload && !plug_mgr->reloadAll())
                     ret = CR_FAILURE;
             }
+            else
+            {
                 for (auto p = parts.begin(); p != parts.end(); p++)
                 {
                     if (!p->size() || (*p)[0] == '-')
@@ -832,6 +834,7 @@ command_result Core::runCommand(color_ostream &con, const std::string &first_, s
                     else if (reload && !plug_mgr->reload(*p))
                         ret = CR_FAILURE;
                 }
+            }
             if (ret != CR_OK)
                 con.printerr("%s failed\n", first.c_str());
             return ret;