-
Notifications
You must be signed in to change notification settings - Fork 493
Widgets/edit field to text area #5201
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Widgets/edit field to text area #5201
Conversation
048658b to
de678b1
Compare
myk002
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
approved, but holding off on merge until after 50.15-r2 is tagged since we're so close to release
| expect.eq(1, e.cursor, 'cursor should be at beginning of string') | ||
| e:onInput{CUSTOM_CTRL_RIGHT=true} | ||
| expect.eq(6, e.cursor, 'goto beginning of next word') | ||
| expect.eq(5, e.cursor, 'goto end of current word') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I was mimicking readline behavior before, but I agree with this change since it matches browser edit field behavior.
|
From testing, there is an issue with focus setting in Also, for activatable edit fields that you can click to set focus and start editing, like the blueprint name in However, if we highlight everything on focus, we should fix another (existing) behavior I noticed when I double clicked to highlight a word, then hit an arrow key. Currently, the cursor gets positioned relative to the beginning of the word when you do this. If a word is highlighted and I hit the left arrow, I'd expect the cursor to be at the beginning of the word, not one position to the left of the word. If a word is highlighted and I hit the right arrow key, I expect the cursor to be just after the last letter of the word, not one position to the right from the first letter of the word. |
testing shows some issues that need to be fixed first
f0da058 to
9028795
Compare
TextArea should not consume up/down chars in one line mode
9028795 to
8e3a79e
Compare
|
Focus is fixed for
|
This PR migrate commonly used
EditFieldwidget to be based onTextAreacomponent.Its inherits all
TextAreafeatures in one line mode, keeping original interface ofEditFieldwidget.Also, I polished one line mode of
TextAreato display cp437 character (◙) instead of remove them.