Add prefer nicknamed to spectate #5386
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
myk002
reviewed
Apr 8, 2025
Member
myk002
left a comment
myk002
left a comment
There was a problem hiding this comment.
needs:
- changelog entry
- actually filling the bucket with data
myk002
reviewed
Apr 12, 2025
myk002
reviewed
Apr 25, 2025
plugins/spectate.cpp
Outdated
Comment on lines
533
to
535
| if (config.prefer_nicknamed) { | ||
| add_bucket(nicknamed_units, units, intervals, weights, NICKNAMED_CITIZEN_PREFERRED_WEIGHT); | ||
| } |
Member
There was a problem hiding this comment.
This effectively removes nicknamed dwarves from the selection pool if prefer_nicknamed is false.
These code reviews take up a lot of my time. Please be sure to test your code carefully.
in my testing turning off the prefer nicknamed used the jobs to categorize them . (i went from 16 nicknamed to 2 job units and 14 other units) so I'm pretty sure this works as i meant it to now
myk002
reviewed
May 3, 2025
Member
myk002
left a comment
myk002
left a comment
There was a problem hiding this comment.
code looks good. please add documentation to the .rst file
myk002
approved these changes
May 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #5305