Fix Items::getDescription #5434
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Display correct quality level for items with "non-displayed" improvements * Add ALL item designations here (and remove "XXwearXX" from other spot) * Obey SHOW_IMP_QUALITY setting
myk002
reviewed
Apr 27, 2025
| if (has_displayed_item_improvements) { | ||
| tmp = '\xAE' + tmp + '\xAF'; // («) + tmp + (») | ||
| addQuality(tmp, item->getImprovementQuality()); | ||
| if (df::global::d_init->display.flags.is_set(d_init_flags1::SHOW_IMP_QUALITY)) |
Member
There was a problem hiding this comment.
although we've traditionally tested globals before using them in the core library, I think this function is well out of the way of the code path that might be hit when globals aren't defined, so this is fine.
myk002
approved these changes
Apr 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5404
Replaces PR #5406 (which was merging from the wrong branch)