merge Process.cpp into a single source file
#5441
Conversation
myk002
left a comment
myk002
left a comment
There was a problem hiding this comment.
ugh, that's grotty, but arguably better than having diverging implementations in different files
library/Process.cpp
Outdated
| #ifndef WIN32 | ||
| #ifndef _DARWIN | ||
| #endif /* ! WIN32 */ | ||
| #include <cstdlib> | ||
| #ifndef WIN32 |
There was a problem hiding this comment.
maybe adding spaces would make the nesting easier to read here.
There was a problem hiding this comment.
oh that's just a mess, lemme make it better
it's because the darwin header does not include <cstdlib> but both linux and windows do. it's probably appropriate to include it in darwin as well, but honestly i have no idea anymore with darwin
yeah that's where i am too. i had aligned the separate files as best i could (using side by side edit) a year or so ago, and even with that they had managed to drift a bit in that relatively limited time |
2 participants
lots of
#ifdefi tried to keep as much commonality as possible. it gets a bit difficult in places