More code modernizations #5445
Merged
More code modernizations #5445
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`std::thread`'s constructor is a template, no reason to type-erase here
This reverts commit 5e50664.
Member
Yeah I used those in |
myk002
approved these changes
May 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most of these changes address removing unnecessary type erasures
Several related to the change to
std::thread;std::threadis polymorphic while our preceding threading library was not. When we converted, we never removed the type erasure the prior library requiredThe other major change is to switch
RunQueryCoreLoopto take astd::functioninstead of a bare function pointer and a type-erased argument list. This makes the functors forRunQueryCoreLoopmore transparent and easier to understand. Hopefully gcc 10 will acceptstd::placeholders. :)