Skip to content

Fix: Improve error handling for config loading #109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
DFanso merged 1 commit into from
Oct 9, 2025
Merged

Fix: Improve error handling for config loading #109

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 14 additions & 7 deletions cmd/cli/store/store.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ type StoreMethods struct {
ring keyring.Keyring
}

//Initializes Keyring instance
// Initializes Keyring instance
func KeyringInit() (*StoreMethods, error) {
ring, err := keyring.Open(keyring.Config{
ServiceName: "commit-msg",
Expand Down Expand Up @@ -69,7 +69,9 @@ func (s *StoreMethods) Save(LLMConfig LLMProvider) error {
if len(data) > 2 {
err = json.Unmarshal(data, &cfg)
if err != nil {
return err
// If unmarshal fails, it might be due to old config format
// Reset to empty config to allow fresh setup
return fmt.Errorf("config file format error: %w. Please delete the config and run setup again", err)
}
}

Expand Down Expand Up @@ -135,7 +137,8 @@ func (s *StoreMethods) DefaultLLMKey() (*LLMProvider, error) {
if len(data) > 2 {
err = json.Unmarshal(data, &cfg)
if err != nil {
return nil, err
// If unmarshal fails, it might be due to old config format
return nil, fmt.Errorf("config file format error: %w. Please delete the config and run setup again", err)
}
} else {
return nil, errors.New("config file is empty, Please add at least one LLM Key")
Expand Down Expand Up @@ -180,7 +183,8 @@ func ListSavedModels() (*Config, error) {
if len(data) > 2 {
err = json.Unmarshal(data, &cfg)
if err != nil {
return nil, err
// If unmarshal fails, it might be due to old config format
return nil, fmt.Errorf("config file format error: %w. Please delete the config and run setup again", err)
}
} else {
return nil, errors.New("config file is empty, Please add at least one LLM Key")
Expand Down Expand Up @@ -213,7 +217,8 @@ func ChangeDefault(Model types.LLMProvider) error {
if len(data) > 2 {
err = json.Unmarshal(data, &cfg)
if err != nil {
return err
// If unmarshal fails, it might be due to old config format
return fmt.Errorf("config file format error: %w. Please delete the config and run setup again", err)
}
}

Expand Down Expand Up @@ -262,7 +267,8 @@ func (s *StoreMethods) DeleteModel(Model types.LLMProvider) error {
if len(data) > 2 {
err = json.Unmarshal(data, &cfg)
if err != nil {
return err
// If unmarshal fails, it might be due to old config format
return fmt.Errorf("config file format error: %w. Please delete the config and run setup again", err)
}
}

Expand Down Expand Up @@ -323,7 +329,8 @@ func (s *StoreMethods) UpdateAPIKey(Model types.LLMProvider, APIKey string) erro
if len(data) > 2 {
err = json.Unmarshal(data, &cfg)
if err != nil {
return err
// If unmarshal fails, it might be due to old config format
return fmt.Errorf("config file format error: %w. Please delete the config and run setup again", err)
}
}

Expand Down
Loading