-
Notifications
You must be signed in to change notification settings - Fork 62
Feature: ancestor face computation function for the scheme #1958
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1958 +/- ##
==========================================
+ Coverage 75.66% 75.68% +0.01%
==========================================
Files 105 105
Lines 18646 18669 +23
==========================================
+ Hits 14109 14130 +21
- Misses 4537 4539 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Co-authored-by: David Knapp <david.knapp@dlr.de>
…ure-ancestor_face
Davknapp
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please fix the failing test-pipeline, then we are ready to merge!
Thanks a lot!
Closes #1738
Describe your changes here:
Add a new function to compute the face number of an ancestor face, given a lower level element and a subface.
Added a universal solution by iterating over the levels and the
element_face_get_parent_facefunction.Maybe we should extend testing, currently only the same and one level above is tested.
All these boxes must be checked by the AUTHOR before requesting review:
Documentation:,Bugfix:,Feature:,Improvement:orOther:.All these boxes must be checked by the REVIEWERS before merging the pull request:
As a reviewer please read through all the code lines and make sure that the code is fully understood, bug free, well-documented and well-structured.
General
Tests
If the Pull request introduces code that is not covered by the github action (for example coupling with a new library):
Scripts and Wiki
script/find_all_source_files.scpto check the indentation of these files.License
doc/(or already has one).