add Destroy UTXO payload #374
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gasby88
reviewed
Jul 27, 2017
core/store/ChainStore/ChainStore.go
Outdated
| } | ||
| for assetId, value := range results { | ||
| if _, ok := quantities[assetId]; !ok { | ||
| quantities[assetId] += value * -1 |
Contributor
There was a problem hiding this comment.
Usage expression quantities[assetId] -= value
Arbio5zt
force-pushed
the
DestroyUTXO
branch
2 times, most recently
from
1624443 to
61a7af6
Compare
Contributor
|
approve |
sharpbear
suggested changes
Jul 27, 2017
Contributor
sharpbear
left a comment
sharpbear
left a comment
There was a problem hiding this comment.
For Destory UTXO tx, needn't check TX balance.
Member
Author
|
thanks for review. added balance check exception when DestroyUTXO payload. but the outputs should be 0. could you helps to check it again,thanks. |
sharpbear
suggested changes
Jul 28, 2017
| } | ||
| } | ||
| if Tx.TxType == tx.IssueAsset { | ||
| if Tx.TxType == tx.IssueAsset || Tx.TxType == tx.DestroyUTXO { |
Contributor
There was a problem hiding this comment.
Destory UTXO should check the output, not input
sharpbear
approved these changes
Jul 28, 2017
Arbio5zt
force-pushed
the
DestroyUTXO
branch
4 times, most recently
from
1f1253f to
a24e651
Compare
add Destroy UTXO payload Signed-off-by: luodanwg <luodan.wg@gmail.com>
Member
Author
|
add validation check of should be destroyed by asset issuer. |
Honglei-Cong
pushed a commit
to Honglei-Cong/DNA
that referenced
this pull request
Nov 27, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The UTXO owner can Destory self controled UTXOs
and will reduce the value of asset total issued quantity.
Signed-off-by: luodanwg luodan.wg@gmail.com