Skip to content

fix: NXDomain should continue to next server if available #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
radu-solomon-dnsf merged 1 commit into from
Jun 27, 2025
Merged

fix: NXDomain should continue to next server if available #7

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ARSoft.Tools.Net/ARSoft.Tools.Net.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
<PackageLicenseExpression>Apache-2.0</PackageLicenseExpression>
<PackageRequireLicenseAcceptance>true</PackageRequireLicenseAcceptance>
<Copyright>Copyright 2010..2024 Alexander Reinert</Copyright>
<VersionPrefix>3.6.1</VersionPrefix>
<VersionPrefix>3.6.2</VersionPrefix>
<AssemblyVersion>$(VersionPrefix)</AssemblyVersion>
<Platforms>AnyCPU;x64;ARM64</Platforms>
</PropertyGroup>
Expand Down
2 changes: 1 addition & 1 deletion ARSoft.Tools.Net/Dns/DnsClientBase.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,7 +157,7 @@ private DnsRawPackage PrepareMessage<TMessage>(TMessage message, out SelectTsigK
{
connection.RestartIdleTimeout(receivedMessage.Message.GetEDnsKeepAliveTimeout());

if (receivedMessage.Message.ReturnCode == ReturnCode.ServerFailure)
Copy link
Collaborator

@puntor puntor Jun 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(question) I might be misunderstanding but if this is in the ARSoft library, it means that anything going over a DnsClient for ARSoft will be subjected to the same logic. If that's the case, would this also mean that this could affect our critical path of DNS resolution beyond local domain resolution only? We've had lots of issues with timeouts on the Zorus side so just making sure I'm not missing something.

Copy link
Author

@radu-solomon-dnsf radu-solomon-dnsf Jun 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct. But the expected behavior at least from our clients is that we try all the DNS servers they have configured before deciding NXDomain is the only answer.

if (receivedMessage.Message.ReturnCode is ReturnCode.ServerFailure or ReturnCode.NxDomain)
{
response = receivedMessage.Message;
continue;
Expand Down