[FIX] : Change 'MemoState&DispatchContext' level in comp trees#1
Open
winterlood wants to merge 1 commit intoDa-Haeng:testfrom
Open
[FIX] : Change 'MemoState&DispatchContext' level in comp trees#1winterlood wants to merge 1 commit intoDa-Haeng:testfrom
winterlood wants to merge 1 commit intoDa-Haeng:testfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context Providers 위치 변경
기존 Main.tsx에 존재하던 MemoDispatch&StateContext Provider의 위치를 App.tsx의 최상위 태그로 옮겼습니다.
따라서 기존 Main.tsx의 데이터를 DetailPage.tsx로 전달하지 못했던 문제를 해결하였습니다.
DetailPage �타입 추가
DetailPage.tsx에 interface로 IMemoItem 타입을 임시로 추가하였습니다.
TS가 적용된 프로젝트인 만큼 아이템 타입이 추론되지 않아 발생할 수 있는 문제를 소거하기 위함입니다.
DetailPage State 임시 렌더링
DetailPage 컴포넌트의 data State의 존재 유무에 따라 렌더링 분기를 설정합니다.