Make crystal apothecary behave better with mixed budding types #805
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vgskye
force-pushed
the
oops-all-citrine
branch
from
46d461f to
3cfa483
Compare
Owner
|
Very much a needed change, thank you! Performance isn't that much of a concern, since the logic runs only very rarely. The code is a tad harder to maintain, but the benefits outweigh the cost by a mile here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this PR rewrites the insertion part of the compensation algorithm to insert the compensation reward stacks slot-by-slot weighted-randomly, which results in mixed budding types having (roughly) correct distribution instead of hashes-first-gets-all. while this does make the algorithm more complex and probably slower, it probably doesn't matter as this isn't a very hot code path.
because, well, this is what happens currently if you let crystal apothecary's compensation run for a sufficiently long time with mixed types of budding:
