FIX: Compatibility with latest Discourse#5
Open
OsamaSayegh wants to merge 1 commit intoDaemonite:masterfrom
Open
FIX: Compatibility with latest Discourse#5OsamaSayegh wants to merge 1 commit intoDaemonite:masterfrom
OsamaSayegh wants to merge 1 commit intoDaemonite:masterfrom
Conversation
|
Would be great if this was accepted, since the component is broken now (but was better than the similar built-in functionality, IMO). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As of discourse/discourse@cd24eff, Discourse now executes JavaScript inside
<script type="text/discourse-plugin">tags in strict mode. The minified JS inside this script tag doesn't work with strict mode enabled, but it also doesn't need to be of type"text/discourse-plugin". So to make the component work with latest Discourse, all we have to do is removetype="text/discourse-plugin" version="0.8"from the<script>tag and this PR does exactly that (the component still works with older versions of Discourse with this change.).