Closed
Conversation
This increases the number of errors that can be reported simultaneously.
The new Theory will also automatically test any new ProductionTableContent classes.
Serialization is completely broken here.
This now includes serialization as dictionary keys, as has always been supported for FactorioObjects.
…ss#448) The initial driver for this was removing the warning that "The `==` operator will silently revert to reference equality if both sides of are the interface type." This is no longer a concern, as reference equality will now do the right thing. As I switched from `ICustomJsonDeserializer` to `QualityObjectSerializer`, I also decided it was a good idea to produce more documentation of how the serialization system worked and what related test failures likely meant.
This fixes shpaass#446 and adds a few tests to prevent its re-occurrence, This also fixes loading errors when the latest autosave is corrupt (truncated, in my experience), by falling back to the original file, but there are no unit tests for that.
.NET 9 changes (fixes) the float->int conversion behavior on x86: https://learn.microsoft.com/en-us/dotnet/core/compatibility/jit/9.0/fp-to-integer
As reported a couple times on Discord, the page list is broken on .NET 9. This fixes that, by removing and preventing the divide-by-zero that (eventually) causes the issue.  This happened because .NET 9 changed (fixed) the float->int conversion behavior on x86: https://learn.microsoft.com/en-us/dotnet/core/compatibility/jit/9.0/fp-to-integer
This applies especially to asteroid chunks: inserters are limited to a maximum of 1 stack of items, regardless of their actual hand size. With this change, the value on the left (0.42 inserters) will be shown regardless of the inserter capacity, since asteroid chunks have a stack size of 1. In general, the calculations are now done based on either the hand size or the stack size, whichever is smaller. 
Prod bonuses are usually limited to +300%, regardless of how much recipe prod has been researched or how many prod modules are used. This limits the bonus to +300%, or the max configured by the mod. It also adds a warning when the maximum is exceeded. This may help people notice their error when they have a +50% bonus from research and enter 50 as the research level.
…hpaass#462) When using both mods, ["rocket-part-productivity-_N_"].effects contains two instances of { change = 0.1, recipe = "maraxsis-rocket-part", type = "change-recipe-productivity" }. Personally, I think this is a bug in one or both mods. That said, Factorio loads and obeys both +10% effects, so now Yafc does too.
Write rocketCapacity to items so we never need to calculate it again in the UI.
This should fix shpaass#454; if the version specified in mod-list.json is not found, we (like Factorio) will now load the newest version instead of failing.
…ummary. (shpaass#466) This appears to fix shpaass#459, but I can't really explain why `!flow.ContainsKey` is the correct test. It gets the correct values for unlinked products, requested products, and requested products with overproduction; tested with Moss from Moss Redesign.
Based on the discussion in shpaass#445 and the suggestion by @DaleStan, this at least partial solves the problem. Figured i might as well Pr it. Not sure if this warrants a change log entry, made one anyway.
Crowdin is a platform to make translations easier. Dalestan brought my attention to it, so I'm adding it to see how it goes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A list of nice-to-have things: