Closes #86 - Add Licenses card in Device View#92
Open
mathieued wants to merge 3 commits intoDanSheps:mainfrom
Open
Closes #86 - Add Licenses card in Device View#92mathieued wants to merge 3 commits intoDanSheps:mainfrom
mathieued wants to merge 3 commits intoDanSheps:mainfrom
Conversation
DanSheps
reviewed
May 29, 2025
| return self.render('netbox_lifecycle/inc/support_contract_info.html', extra_context=context) | ||
| context = {'max_items_display': max_items_display, 'licenses': licenses, 'support_contract': support_contract, | ||
| 'lifecycle_info': lifecycle_info} | ||
| return self.render('netbox_lifecycle/inc/licenses_info.html', extra_context=context) |
Owner
There was a problem hiding this comment.
At a glance, this looks to remove the lifecycle information. Instead of removing this and including at the bottom, it is likely better if you only include the card as a new card and only on the device page (not on other pages).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update after closing of #90 (see comments for details).
Closes #86 to add a new card to reference Licenses assigned to Device.
As this new card is displaying a table with possibly multiple Licenses assigned to the device, I've set a limit display of 5 Licenses in the card. This could be discussed, but this avoids the usage of htmx and to comply with more complex cards as Services or Images.