Move many default property values to header file#3
Open
DarioGHub wants to merge 7 commits intoDaniFoldi:masterfrom
Open
Move many default property values to header file#3DarioGHub wants to merge 7 commits intoDaniFoldi:masterfrom
DarioGHub wants to merge 7 commits intoDaniFoldi:masterfrom
Conversation
import -> include, add step_count calc
Added call to update, renamed dt to steps, step_count now calculated, a few wiring notes, and some serial output.
Rename dt -> steps, step_count now calculated
dt renamed steps
loopCallback() was not reached if entered update() with repeat=1; repeat-- resulted in update returning. Constructors contained repeated assignments; moved them to the header file. Constructors with >2 params update the property values.
Moved majority of default property value assignments here from constructors in cpp. Readability: function pointers assigned nullptr in place of 0.
DarioGHub
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Leave cpp file with fewer lines, and attempt to make the examples more understandable for users.