Draft
Conversation
Refactor `SparsemaxFunction` to improve modularity and add property-based testing. * **Refactor `SparsemaxFunction`** - Create `_threshold_and_support` sub-function to handle threshold and support computation logic. - Create `_compute_gradient` sub-function to handle gradient computation logic. - Move reshaping logic to sub-functions and ensure `ctx` operations are done in `forward` and `backward` only. * **Add Unit Tests** - Add unit tests for `_threshold_and_support` sub-function. - Add unit tests for `_compute_gradient` sub-function. - Add unit tests for reshaping logic sub-functions. * **Add Property-Based Tests** - Add hypothesis property-based testing for `_threshold_and_support` sub-function. - Add hypothesis property-based testing for `_compute_gradient` sub-function. --- For more details, open the [Copilot Workspace session](https://copilot-workspace.githubnext.com/DanielAvdar/activations-plus?shareId=XXXX-XXXX-XXXX-XXXX).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor
SparsemaxFunctionto improve modularity and add property-based testing.Refactor
SparsemaxFunction_threshold_and_supportsub-function to handle threshold and support computation logic._compute_gradientsub-function to handle gradient computation logic.ctxoperations are done inforwardandbackwardonly.Add Unit Tests
_threshold_and_supportsub-function._compute_gradientsub-function.Add Property-Based Tests
_threshold_and_supportsub-function._compute_gradientsub-function.For more details, open the Copilot Workspace session.