Form Simplification and Upgrade [potential BC]#66
Open
claytondaley wants to merge 1 commit intoDanielss89:masterfrom
Open
Form Simplification and Upgrade [potential BC]#66claytondaley wants to merge 1 commit intoDanielss89:masterfrom
claytondaley wants to merge 1 commit intoDanielss89:masterfrom
Conversation
claytondaley
force-pushed
the
form-upgrades
branch
from
74a8a8f to
c651632
Compare
…in top answer at http://stackoverflow.com/questions/14667621/zf2-optimize-for-high-traffic) - CreateForm and EditForm add hydrator (per ZfcUser settings) in `__construct`. This makes it available to extend during the form `init` event. - Converted EditForm to inherit directly from Base rather than indirectly through Register (requires ZfcUser PR) - Converted EditForm to store data using `$form->bind($object)` pattern often used in Zend Forms (requires ZfcUser PR to avoid sending password to browser) - Forms now use an enhanced Validation Group logic. Elements are selectively excluded based on specific options or attributes. This significantly improves extensibility. - Cleaned out old helper code - Now repopulates disabled fields (side-effect)
claytondaley
force-pushed
the
form-upgrades
branch
from
c651632 to
b850524
Compare
|
Any progress on this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NOTE: This PR requires ZfcUser PR #562 and ZfcUser PR #564
NOTE: This PR may break backwards compatibility because it defaults to underscore notation for form fields. This could be changed by supporting a flag on the hydrator, but we won't necessarily know the right defaults for all users.
This patch now rewrites significant parts of ZfcUserAdmin:
bind()pattern. This covers all changes in PR Binding User to Edit Form fixes issues #30 and #31 #50 except that the hydrator is created in__constructso it is available to extend during the 'init' event.This eliminated the need for lots of support infrastructure in these classes. As a side-effect, the new code supports a broader set of Zend Form features.
P.S. Due to the increased size of this change -- and the simplicity and power of the form change --, I moved it to a separate PR.