Skip to content

Conversation

@Dargon789
Copy link
Owner

@Dargon789 Dargon789 commented Oct 27, 2025

Summary by Sourcery

Add a GitHub Actions workflow to automate Docker image builds, tagging, caching, pushing to a registry, and signing with cosign, triggered on a daily schedule, main branch updates, semver tag releases, and pull requests.

New Features:

  • Introduce a Docker build-and-push workflow using GitHub Actions to create and publish multi-platform images on a schedule, main branch pushes, and semver tag releases.
  • Integrate cosign to sign published Docker images automatically on non-pull-request runs.

Enhancements:

  • Set up Docker Buildx and GitHub Actions cache-to/cache-from for optimized multi-platform builds and faster rebuilds.

CI:

  • Add .github/workflows/docker.yml to handle Docker build, push, metadata extraction, and signing processes.

Signed-off-by: Dargon789 <64915515+Dargon789@users.noreply.github.com>
@codesandbox
Copy link

codesandbox bot commented Oct 27, 2025

Review or Edit in CodeSandbox

Open the branch in Web EditorVS CodeInsiders

Open Preview

@gemini-code-assist
Copy link

Note

Gemini is unable to generate a summary for this pull request due to the file types involved not being currently supported.

@vercel
Copy link

vercel bot commented Oct 27, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
interface-web Ready Ready Preview Comment Oct 27, 2025 3:51am

@sourcery-ai
Copy link

sourcery-ai bot commented Oct 27, 2025

Reviewer's Guide

Introduces a new GitHub Actions workflow (.github/workflows/docker.yml) to automate building, tagging, pushing, and signing Docker images on scheduled runs, pushes to main, and pull requests.

Flow diagram for Docker image build and sign process in CI

flowchart TD
  Start(["Workflow Triggered (push, PR, schedule)"]) --> Checkout(["Checkout Repository"])
  Checkout --> Buildx(["Set up Docker Buildx"])
  Buildx --> Metadata(["Extract Docker Metadata"])
  Metadata --> BuildPush(["Build and Push Docker Image"])
  BuildPush -->|if not PR| Login(["Log into Docker Registry"])
  BuildPush -->|if not PR| Sign(["Sign Docker Image (Cosign)"])
  Sign --> Rekor(["Rekor Transparency Log"])
Loading

File-Level Changes

Change Details Files
Define workflow triggers and environment settings
  • Added schedule, push (branches and semver tags), and pull_request triggers
  • Declared REGISTRY and IMAGE_NAME environment variables
.github/workflows/docker.yml
Implement build job with Docker build, push, and signing
  • Configured job permissions (contents, packages, id-token) and runner
  • Checked out code and installed cosign except on PRs
  • Set up Docker Buildx for multi-platform builds and cache management
  • Logged into container registry when not in PR context
  • Used docker/metadata-action to generate tags and labels
  • Built and pushed the image with cache-from/to settings
  • Signed the pushed image digest using cosign and GitHub OIDC
.github/workflows/docker.yml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@snyk-io
Copy link

snyk-io bot commented Oct 27, 2025

Snyk checks have passed. No issues have been found so far.

Status Scanner Critical High Medium Low Total (0)
Open Source Security 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

@cloudflare-workers-and-pages
Copy link

Deploying uniswap with  Cloudflare Pages  Cloudflare Pages

Latest commit: 1394135
Status: ✅  Deploy successful!
Preview URL: https://a4def9dd.uniswap-omj.pages.dev
Branch Preview URL: https://dargon789-patch-2.uniswap-omj.pages.dev

View logs

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes and found some issues that need to be addressed.

Prompt for AI Agents
Please address the comments from this code review:

## Individual Comments

### Comment 1
<location> `.github/workflows/docker.yml:26-28` </location>
<code_context>
+
+
+jobs:
+  build:
+    - name: Build the Docker image
+      run: docker build . --file path/to/Dockerfile --tag my-image-name:$(date +%s)
+
+  runs-on: ubuntu-latest
</code_context>

<issue_to_address>
**issue (bug_risk):** The 'build' job is incorrectly defined as a step, not a job.

The 'build:' section should be nested under a job with 'runs-on' and 'permissions', and its steps placed within a 'steps:' array. Otherwise, this will result in a workflow syntax error.
</issue_to_address>

### Comment 2
<location> `.github/workflows/docker.yml:28` </location>
<code_context>
+jobs:
+  build:
+    - name: Build the Docker image
+      run: docker build . --file path/to/Dockerfile --tag my-image-name:$(date +%s)
+
+  runs-on: ubuntu-latest
</code_context>

<issue_to_address>
**suggestion:** Hardcoded Dockerfile path and image tag may not be optimal.

Consider making the Dockerfile path and image tag configurable, and use metadata-based tags for consistency with the workflow.
</issue_to_address>

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@Dargon789 Dargon789 merged commit 73418e6 into uniswap/main-foundry-ux Oct 27, 2025
15 of 17 checks passed
@Dargon789 Dargon789 deleted the Dargon789-patch-2 branch October 27, 2025 04:16
@Dargon789 Dargon789 linked an issue Nov 13, 2025 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

#Docker image build and sign process in CI

2 participants