Open
Conversation
Review or Edit in CodeSandboxOpen the branch in Web Editor • VS Code • Insiders |
|
|
|
@taylanpince is attempting to deploy a commit to the Foundry development Team on Vercel. A member of the Team first needs to authorize it. |
Reviewer's GuideFinalize the 3.0.0 release across the monorepo by promoting multiple packages from beta to stable, adding consolidated 3.0.0 changelog entries, and cleaning up processed Changeset files. Flow diagram for promoting packages from beta to 3.0.0 stableflowchart LR
A[Beta_versions 3.0.0-beta.19_and_earlier] --> B[Accumulate_changeset_files]
B --> C[Generate_consolidated_3.0.0_changelog_entries]
C --> D[Update_package_json_versions_to_3.0.0]
D --> E[Update_repo_tooling_versions_to_0.0.1]
E --> F[Publish_stable_packages]
F --> G[Remove_processed_changeset_files]
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request marks a significant milestone by releasing version 3.0.0 for the core Sequence packages and version 0.0.1 for several repository utility packages. It integrates all development efforts from the beta phase, updating package versions and providing comprehensive changelog entries for the new stable releases. The changes reflect a cleanup of release-related artifacts, ensuring a streamlined and accurate version history. Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey - I've found 8 issues
Prompt for AI Agents
Please address the comments from this code review:
## Individual Comments
### Comment 1
<location path="packages/wallet/wdk/CHANGELOG.md" line_range="10" />
<code_context>
+- f68be62: ethauth support
+- 49d8a2f: New chains, minor fixes
+- 3411232: Beta release with dapp connector fixes
+- 23cb9e9: New chains, relayer rpc fix
+- f5f6a7a: dapp-client updates
+- e7de3b1: Fix signer 404 error, minor fixes
</code_context>
<issue_to_address>
**nitpick (typo):** Consider capitalizing the acronym "RPC" in "relayer rpc fix".
This will keep acronym capitalization consistent with entries like EOA and RC5.
```suggestion
- 23cb9e9: New chains, relayer RPC fix
```
</issue_to_address>
### Comment 2
<location path="packages/wallet/dapp-client/CHANGELOG.md" line_range="10" />
<code_context>
+- f68be62: ethauth support
+- 49d8a2f: New chains, minor fixes
+- 3411232: Beta release with dapp connector fixes
+- 23cb9e9: New chains, relayer rpc fix
+- f5f6a7a: dapp-client updates
+- e7de3b1: Fix signer 404 error, minor fixes
</code_context>
<issue_to_address>
**nitpick (typo):** Consider capitalizing "RPC" in this entry.
This will keep acronym capitalization consistent with the rest of the changelog.
```suggestion
- 23cb9e9: New chains, relayer RPC fix
```
</issue_to_address>
### Comment 3
<location path="packages/wallet/core/CHANGELOG.md" line_range="10" />
<code_context>
+- f68be62: ethauth support
+- 49d8a2f: New chains, minor fixes
+- 3411232: Beta release with dapp connector fixes
+- 23cb9e9: New chains, relayer rpc fix
+- f5f6a7a: dapp-client updates
+- e7de3b1: Fix signer 404 error, minor fixes
</code_context>
<issue_to_address>
**nitpick (typo):** Acronym "rpc" should likely be uppercase.
Consider capitalizing RPC in this entry for consistency with standard acronym usage.
```suggestion
- 23cb9e9: New chains, relayer RPC fix
```
</issue_to_address>
### Comment 4
<location path="packages/services/relayer/CHANGELOG.md" line_range="10" />
<code_context>
+- f68be62: ethauth support
+- 49d8a2f: New chains, minor fixes
+- 3411232: Beta release with dapp connector fixes
+- 23cb9e9: New chains, relayer rpc fix
+- f5f6a7a: dapp-client updates
+- e7de3b1: Fix signer 404 error, minor fixes
</code_context>
<issue_to_address>
**nitpick (typo):** Use standard capitalization for "RPC".
So this line would become: `New chains, relayer RPC fix`.
```suggestion
- 23cb9e9: New chains, relayer RPC fix
```
</issue_to_address>
### Comment 5
<location path="packages/services/api/CHANGELOG.md" line_range="10" />
<code_context>
+- f68be62: ethauth support
+- 49d8a2f: New chains, minor fixes
+- 3411232: Beta release with dapp connector fixes
+- 23cb9e9: New chains, relayer rpc fix
+- f5f6a7a: dapp-client updates
+- e7de3b1: Fix signer 404 error, minor fixes
</code_context>
<issue_to_address>
**nitpick (typo):** Consider capitalizing the "RPC" acronym.
Updating this entry to "relayer RPC fix" will match the existing acronym style used elsewhere in the changelog.
```suggestion
- 23cb9e9: New chains, relayer RPC fix
```
</issue_to_address>
### Comment 6
<location path="packages/utils/abi/CHANGELOG.md" line_range="10" />
<code_context>
+- f68be62: ethauth support
+- 49d8a2f: New chains, minor fixes
+- 3411232: Beta release with dapp connector fixes
+- 23cb9e9: New chains, relayer rpc fix
+- f5f6a7a: dapp-client updates
+- e7de3b1: Fix signer 404 error, minor fixes
</code_context>
<issue_to_address>
**nitpick (typo):** Minor acronym capitalization tweak for "rpc".
Consider changing this to "relayer RPC fix" to match acronym capitalization elsewhere in the changelog.
```suggestion
- 23cb9e9: New chains, relayer RPC fix
```
</issue_to_address>
### Comment 7
<location path="packages/wallet/primitives/CHANGELOG.md" line_range="10" />
<code_context>
+- f68be62: ethauth support
+- 49d8a2f: New chains, minor fixes
+- 3411232: Beta release with dapp connector fixes
+- 23cb9e9: New chains, relayer rpc fix
+- f5f6a7a: dapp-client updates
+- e7de3b1: Fix signer 404 error, minor fixes
</code_context>
<issue_to_address>
**nitpick (typo):** Standardize "RPC" acronym capitalization.
Use “relayer RPC fix” here to match the capitalization used elsewhere.
```suggestion
- 23cb9e9: New chains, relayer RPC fix
```
</issue_to_address>
### Comment 8
<location path="packages/services/userdata/CHANGELOG.md" line_range="10" />
<code_context>
+- f68be62: ethauth support
+- 49d8a2f: New chains, minor fixes
+- 3411232: Beta release with dapp connector fixes
+- 23cb9e9: New chains, relayer rpc fix
+- f5f6a7a: dapp-client updates
+- e7de3b1: Fix signer 404 error, minor fixes
</code_context>
<issue_to_address>
**nitpick (typo):** Use uppercase "RPC" instead of "rpc".
Keeps acronym capitalization consistent with the rest of the changelog.
```suggestion
- 23cb9e9: New chains, relayer RPC fix
```
</issue_to_address>Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request automates the 3.0.0 release by updating package versions and consolidating changelogs. The changes are mostly mechanical and look correct for a release PR. I've identified a couple of minor issues in the generated changelogs: some contain a redundant '3.0.0 release' entry, and others have an 'Updated dependencies' line without a commit hash. I've left specific comments suggesting the removal of these lines to improve the clarity and correctness of the changelogs.
Owner
Author
|
@Mergifyio refresh |
✅ Pull request refreshed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by Sourcery
Cut the stable 3.0.0 release across wallet, services, and utils packages and finalize internal repo package versions.
Enhancements:
Chores: