Skip to content

Comments

[test optimization] Improve cypress - RUM integration#7600

Merged
juan-fernandez merged 3 commits intomasterfrom
juan-fernandez/fix-rum-cypress-integration
Feb 23, 2026
Merged

[test optimization] Improve cypress - RUM integration#7600
juan-fernandez merged 3 commits intomasterfrom
juan-fernandez/fix-rum-cypress-integration

Conversation

@juan-fernandez
Copy link
Collaborator

@juan-fernandez juan-fernandez commented Feb 23, 2026

What does this PR do?

  • Improve how we grab the original window.
  • Use datadog-ci-visibility-test-execution-id cookie instead of cypress global variable, as this is how it works for other integrations.
  • Use DD_RUM.stopSession.
  • Add a 500ms delay to give time to RUM to flush, configurable with DD_CIVISIBILITY_RUM_FLUSH_WAIT_MILLIS, like other frameworks.
  • Do a best effort approach to work with testIsolation:false, which normally wouldn't work because the page does not refresh between tests.

Motivation

Improve the likelihood of cypress + RUM integration to succeed.

Additional Notes

Tested manually, as this includes using real RUM

@github-actions
Copy link
Contributor

github-actions bot commented Feb 23, 2026

Overall package size

Self size: 4.78 MB
Deduped: 5.63 MB
No deduping: 5.63 MB

Dependency sizes | name | version | self size | total size | |------|---------|-----------|------------| | import-in-the-middle | 2.0.6 | 81.92 kB | 816.75 kB | | dc-polyfill | 0.1.10 | 26.73 kB | 26.73 kB |

🤖 This report was automatically generated by heaviest-objects-in-the-universe

@codecov
Copy link

codecov bot commented Feb 23, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 80.31%. Comparing base (5e3de4e) to head (178bd54).
⚠️ Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7600      +/-   ##
==========================================
- Coverage   80.32%   80.31%   -0.01%     
==========================================
  Files         733      733              
  Lines       31546    31547       +1     
==========================================
  Hits        25338    25338              
- Misses       6208     6209       +1     
Flag Coverage Δ
aiguard-macos 38.93% <ø> (-0.10%) ⬇️
aiguard-ubuntu 39.06% <ø> (-0.10%) ⬇️
aiguard-windows 38.79% <ø> (-0.11%) ⬇️
apm-capabilities-tracing-macos 48.59% <ø> (+<0.01%) ⬆️
apm-capabilities-tracing-ubuntu 48.66% <ø> (+<0.01%) ⬆️
apm-capabilities-tracing-windows 48.36% <ø> (-0.01%) ⬇️
apm-integrations-child-process 38.51% <ø> (-0.10%) ⬇️
apm-integrations-couchbase-18 37.28% <ø> (-0.10%) ⬇️
apm-integrations-couchbase-eol 37.76% <ø> (-0.10%) ⬇️
apm-integrations-oracledb 37.73% <ø> (-0.09%) ⬇️
appsec-express 55.53% <ø> (-0.07%) ⬇️
appsec-fastify 51.84% <ø> (-0.07%) ⬇️
appsec-graphql 52.03% <ø> (-0.07%) ⬇️
appsec-kafka 44.49% <ø> (-0.08%) ⬇️
appsec-ldapjs 44.09% <ø> (-0.08%) ⬇️
appsec-lodash 43.78% <ø> (-0.08%) ⬇️
appsec-macos 58.61% <ø> (-0.07%) ⬇️
appsec-mongodb-core 48.84% <ø> (-0.19%) ⬇️
appsec-mongoose 49.64% <ø> (-0.08%) ⬇️
appsec-mysql 51.02% <ø> (-0.17%) ⬇️
appsec-node-serialize 43.29% <ø> (-0.08%) ⬇️
appsec-passport 47.78% <ø> (-0.08%) ⬇️
appsec-postgres 50.75% <ø> (-0.07%) ⬇️
appsec-sourcing 42.64% <ø> (-0.08%) ⬇️
appsec-template 43.46% <ø> (-0.08%) ⬇️
appsec-ubuntu 58.69% <ø> (-0.07%) ⬇️
appsec-windows 58.45% <ø> (-0.09%) ⬇️
instrumentations-instrumentation-bluebird 32.21% <ø> (-0.10%) ⬇️
instrumentations-instrumentation-body-parser 40.52% <ø> (-0.09%) ⬇️
instrumentations-instrumentation-child_process 37.82% <ø> (-0.10%) ⬇️
instrumentations-instrumentation-cookie-parser 34.25% <ø> (-0.09%) ⬇️
instrumentations-instrumentation-express 34.58% <ø> (-0.09%) ⬇️
instrumentations-instrumentation-express-mongo-sanitize 34.38% <ø> (-0.09%) ⬇️
instrumentations-instrumentation-express-session 40.14% <ø> (-0.09%) ⬇️
instrumentations-instrumentation-fs 31.81% <ø> (-0.10%) ⬇️
instrumentations-instrumentation-generic-pool 29.76% <ø> (ø)
instrumentations-instrumentation-http 39.86% <ø> (-0.10%) ⬇️
instrumentations-instrumentation-knex 32.21% <ø> (-0.10%) ⬇️
instrumentations-instrumentation-mongoose 33.37% <ø> (-0.09%) ⬇️
instrumentations-instrumentation-multer 40.26% <ø> (-0.09%) ⬇️
instrumentations-instrumentation-mysql2 38.30% <ø> (-0.10%) ⬇️
instrumentations-instrumentation-passport 44.09% <ø> (-0.08%) ⬇️
instrumentations-instrumentation-passport-http 43.76% <ø> (-0.08%) ⬇️
instrumentations-instrumentation-passport-local 44.31% <ø> (-0.08%) ⬇️
instrumentations-instrumentation-pg 37.72% <ø> (-0.10%) ⬇️
instrumentations-instrumentation-promise 32.13% <ø> (-0.10%) ⬇️
instrumentations-instrumentation-promise-js 32.14% <ø> (-0.10%) ⬇️
instrumentations-instrumentation-q 32.18% <ø> (-0.10%) ⬇️
instrumentations-instrumentation-url 32.10% <ø> (-0.10%) ⬇️
instrumentations-instrumentation-when 32.15% <ø> (-0.10%) ⬇️
llmobs-ai 41.33% <ø> (-0.09%) ⬇️
llmobs-anthropic 40.33% <ø> (-0.09%) ⬇️
llmobs-bedrock 39.26% <ø> (-0.08%) ⬇️
llmobs-google-genai 39.85% <ø> (-0.09%) ⬇️
llmobs-langchain 39.43% <ø> (-0.07%) ⬇️
llmobs-openai 44.14% <ø> (-0.09%) ⬇️
llmobs-vertex-ai 40.12% <ø> (-0.02%) ⬇️
platform-core 29.71% <ø> (ø)
platform-esbuild 32.89% <ø> (ø)
platform-instrumentations-misc 40.53% <ø> (ø)
platform-shimmer 36.14% <ø> (ø)
platform-unit-guardrails 31.27% <ø> (ø)
plugins-azure-event-hubs 24.02% <ø> (ø)
plugins-azure-service-bus 23.42% <ø> (ø)
plugins-bullmq 43.67% <ø> (-0.12%) ⬇️
plugins-cassandra 37.77% <ø> (-0.09%) ⬇️
plugins-cookie 25.08% <ø> (ø)
plugins-cookie-parser 24.87% <ø> (ø)
plugins-crypto 24.72% <ø> (ø)
plugins-dd-trace-api 38.37% <ø> (-0.10%) ⬇️
plugins-express-mongo-sanitize 25.04% <ø> (ø)
plugins-express-session 24.83% <ø> (ø)
plugins-fastify 42.28% <ø> (-0.09%) ⬇️
plugins-fetch 38.32% <ø> (-0.09%) ⬇️
plugins-fs 38.61% <ø> (-0.10%) ⬇️
plugins-generic-pool 24.06% <ø> (ø)
plugins-google-cloud-pubsub 45.46% <ø> (-0.09%) ⬇️
plugins-grpc 40.97% <ø> (-0.09%) ⬇️
plugins-handlebars 25.08% <ø> (ø)
plugins-hapi 40.15% <ø> (-0.09%) ⬇️
plugins-hono 40.41% <ø> (-0.09%) ⬇️
plugins-ioredis 38.42% <ø> (-0.10%) ⬇️
plugins-knex 24.80% <ø> (ø)
plugins-ldapjs 22.61% <ø> (ø)
plugins-light-my-request 24.48% <ø> (ø)
plugins-limitd-client 32.50% <ø> (-0.10%) ⬇️
plugins-lodash 24.13% <ø> (ø)
plugins-mariadb 39.50% <ø> (-0.10%) ⬇️
plugins-memcached 38.15% <ø> (-0.10%) ⬇️
plugins-microgateway-core 39.18% <ø> (-0.09%) ⬇️
plugins-moleculer 40.53% <ø> (-0.09%) ⬇️
plugins-mongodb 39.20% <ø> (-0.09%) ⬇️
plugins-mongodb-core 39.04% <ø> (-0.10%) ⬇️
plugins-mongoose 38.86% <ø> (-0.09%) ⬇️
plugins-multer 24.83% <ø> (ø)
plugins-mysql 39.14% <ø> (-0.13%) ⬇️
plugins-mysql2 39.27% <ø> (-0.10%) ⬇️
plugins-node-serialize 25.12% <ø> (ø)
plugins-opensearch 37.60% <ø> (-0.09%) ⬇️
plugins-passport-http 24.91% <ø> (ø)
plugins-postgres 35.70% <ø> (-0.08%) ⬇️
plugins-process 24.72% <ø> (ø)
plugins-pug 25.08% <ø> (ø)
plugins-redis 38.89% <ø> (-0.09%) ⬇️
plugins-router 43.03% <ø> (-0.09%) ⬇️
plugins-sequelize 23.66% <ø> (ø)
plugins-test-and-upstream-amqp10 38.49% <ø> (+0.05%) ⬆️
plugins-test-and-upstream-amqplib 43.85% <ø> (+0.05%) ⬆️
plugins-test-and-upstream-apollo 39.03% <ø> (-0.09%) ⬇️
plugins-test-and-upstream-avsc 38.70% <ø> (-0.10%) ⬇️
plugins-test-and-upstream-bunyan 33.80% <ø> (-0.10%) ⬇️
plugins-test-and-upstream-connect 40.82% <ø> (-0.09%) ⬇️
plugins-test-and-upstream-graphql 40.16% <ø> (-0.10%) ⬇️
plugins-test-and-upstream-koa 40.39% <ø> (-0.09%) ⬇️
plugins-test-and-upstream-protobufjs 38.94% <ø> (-0.10%) ⬇️
plugins-test-and-upstream-rhea 44.10% <ø> (-0.13%) ⬇️
plugins-undici 39.12% <ø> (-0.09%) ⬇️
plugins-url 24.72% <ø> (ø)
plugins-valkey 38.07% <ø> (-0.10%) ⬇️
plugins-vm 24.72% <ø> (ø)
plugins-winston 34.00% <ø> (-0.09%) ⬇️
plugins-ws 41.92% <ø> (-0.09%) ⬇️
profiling-macos 39.85% <ø> (-0.10%) ⬇️
profiling-ubuntu 39.98% <ø> (-0.10%) ⬇️
profiling-windows 41.20% <ø> (-0.10%) ⬇️
serverless-azure-functions-client 23.75% <ø> (ø)
serverless-azure-functions-eventhubs 23.75% <ø> (ø)
serverless-azure-functions-servicebus 23.75% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pr-commenter
Copy link

pr-commenter bot commented Feb 23, 2026

Benchmarks

Benchmark execution time: 2026-02-23 15:03:30

Comparing candidate commit 178bd54 in PR branch juan-fernandez/fix-rum-cypress-integration with baseline commit 5e3de4e in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 228 metrics, 32 unstable metrics.

@juan-fernandez juan-fernandez marked this pull request as ready for review February 23, 2026 14:52
@juan-fernandez juan-fernandez requested a review from a team as a code owner February 23, 2026 14:52
@juan-fernandez juan-fernandez merged commit f370fb3 into master Feb 23, 2026
792 checks passed
@juan-fernandez juan-fernandez deleted the juan-fernandez/fix-rum-cypress-integration branch February 23, 2026 15:33
@dd-octo-sts dd-octo-sts bot mentioned this pull request Feb 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants