Skip to content

Conversation

@jade-guiton-dd
Copy link

Motivation

This PR in Datadog Agent removed old logic that was mapping attributes from exception span events onto the parent span. This used to be necessary before we started supporting span events, but is now causing duplicate entries in Error Tracking. This PR updates the corresponding test.

Changes

I replaced the test which checks for error.type / error.stack attributes on the span by one which checks for a span event with analogous attributes.

Workflow

  1. ⚠️ Create your PR as draft ⚠️
  2. Work on you PR until the CI passes
  3. Mark it as ready for review
    • Test logic is modified? -> Get a review from RFC owner.
    • Framework is modified, or non obvious usage of it -> get a review from R&P team

🚀 Once your PR is reviewed and the CI green, you can merge it!

🛟 #apm-shared-testing 🛟

Reviewer checklist

  • Anything but tests/ or manifests/ is modified ? I have the approval from R&P team
  • A docker base image is modified?
    • the relevant build-XXX-image label is present
  • A scenario is added, removed or renamed?

@github-actions
Copy link
Contributor

CODEOWNERS have been resolved as:

tests/integrations/test_open_telemetry.py                               @DataDog/system-tests-core

@jade-guiton-dd jade-guiton-dd changed the title [OTELS-844] Check for exception span events instead of promoted attributes [OTEL-2899] Check for exception span events instead of promoted attributes Jan 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants