use 204 instead of 404 if chunk does not exist#1
Open
bit wants to merge 1 commit intoDataGreed:masterfrom
Open
use 204 instead of 404 if chunk does not exist#1bit wants to merge 1 commit intoDataGreed:masterfrom
bit wants to merge 1 commit intoDataGreed:masterfrom
Conversation
sending 404 is considered an error in many layers of the stack. using http status code 304 avoids those warnings/errors in the django backend and browser. 204 is the recommended response code according to https://github.com/23/resumable.js
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
sending 404 is considered an error in many layers of the stack.
using http status code 304 avoids those warnings/errors in the django backend and browser.
204 is the recommended response code according to https://github.com/23/resumable.js