Conversation
xolotlatoani
force-pushed
the
feature/mongo-oidc
branch
from
6547c1b to
e189b0f
Compare
IlyaEp
left a comment
IlyaEp
left a comment
There was a problem hiding this comment.
Thanks for contributing! I’ll have another look after we address or discuss the current issues
| for (String browser : browsers) { | ||
| try { | ||
| // Check if browser exists | ||
| Process process = runtime.exec(new String[] {"which", browser}); |
There was a problem hiding this comment.
not familiar with that. I can try to add if you have an example?
| private @Nullable ExecutorService executorService; | ||
| private @Nullable Engine sharedEngine; | ||
| private @NotNull ShellHolder shellHolder; | ||
| private MongoConnection mongoConnection; |
There was a problem hiding this comment.
Do not cache the DB connection. If you need to cache the token, cache that instead
There was a problem hiding this comment.
I was trying to find a way to re-use the same connection across the tabs in DG, is there a way to do that?
| return null; | ||
| } | ||
|
|
||
| Server server = new Server(); |
There was a problem hiding this comment.
Is it possible to bind the server lifecycle to the driver and initialize it lazily?
There was a problem hiding this comment.
or come back later to that?
version update adds support for mongo-oidc
xolotlatoani
force-pushed
the
feature/mongo-oidc
branch
from
9e83c89 to
1d9da3c
Compare
version update adds support for mongo-oidc
…/mongo-oidc # Conflicts: # build.gradle # src/main/java/com/dbschema/MongoJdbcDriver.java
|
Updated the PR. Sorry for the delay, I finally had time to come back to this. |
2 participants
No description provided.