-
Notifications
You must be signed in to change notification settings - Fork 1
BDMS-463: Docker Compose Checkup #377
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR improves the development environment startup by preventing unnecessary database rebuilds and ensuring proper initialization order. The changes allow developers to restart the application without losing existing data while still supporting fresh database seeding when needed.
Changes:
- Removed automatic database wipe on development startup
- Added prerequisite checks to ensure lexicon/parameter data exists before seeding
- Implemented conditional seeding that skips if data already exists
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| core/app.py | Removed erase_and_rebuild_db() call and added skip_if_exists flag to seeding |
| transfers/seed.py | Added prerequisite validation, existence check, and skip logic to prevent duplicate seeds |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.
|
@jirhiker Ok print statements added and I changed the function name as suggested. |
Why
This PR addresses the following problem / context:
How
Implementation summary - the following was changed / added / removed:
Notes
Any special considerations, workarounds, or follow-up work to note?