fix: change NMAMinorTraceChemistry volume from Float to Integer #380
+54
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update volume field type to match source database schema (NM_Aquifer_Dev_DB). Changes: - Update model type in db/nma_legacy.py - Add _safe_int() helper in transfer script - Update tests to use integer values - Add Alembic migration to alter column type Closes #379 Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR aligns the NMAMinorTraceChemistry.volume field with the source database schema by changing its type from Float to Integer, as the source database defines this column as int and all actual data values are integers.
Changes:
- Updated model field type from Float to Integer
- Added integer conversion helper method in transfer script
- Updated test assertions to use integer values
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| db/nma_legacy.py | Changed volume field type from Float to Integer |
| transfers/minor_trace_chemistry_transfer.py | Added _safe_int() helper and updated volume conversion from float to int |
| tests/test_nma_chemistry_lineage.py | Updated test values from 500.0 to 500 to match new Integer type |
| alembic/versions/g4a5b6c7d8e9_change_minor_trace_volume_to_int.py | Added migration to alter volume column type with proper upgrade/downgrade logic |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
NMAMinorTraceChemistry.volumefield type fromFloattoIntegerto match source database schemaDetails
The source database (
NM_Aquifer_Dev_DB) defines the Volume column asint default 0. All actual data values are integers. This change aligns the model with the source schema for consistency.Changes
db/nma_legacy.py: Update volume field typetransfers/minor_trace_chemistry_transfer.py: Add_safe_int()helper, use for volumetests/test_nma_chemistry_lineage.py: Update test values from500.0to500alembic/versions/g4a5b6c7d8e9_*: Migration to alter column typeTest plan
Closes #379
🤖 Generated with Claude Code