Skip to content

Metrics editor requires the parent node types #1645

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
shangyian merged 1 commit into from
Jan 10, 2026
Merged

Metrics editor requires the parent node types #1645

shangyian merged 1 commit into from
Jan 10, 2026

Conversation

@shangyian
Copy link
Collaborator

@shangyian shangyian commented Jan 9, 2026

Summary

The metrics editor UI now supports derived metrics, which requires that its parent nodes' types are available via GraphQL.

Test Plan

  • PR has an associated issue: #
  • make check passes
  • make test shows 100% unit test coverage

Deployment Plan

@netlify
Copy link

netlify bot commented Jan 9, 2026 •
edited
Loading

✅ Deploy Preview for thriving-cassata-78ae72 canceled.

Name Link
🔨 Latest commit b830e4b
🔍 Latest deploy log https://app.netlify.com/projects/thriving-cassata-78ae72/deploys/69619522488bb400083ce873

@shangyian shangyian changed the title The metrics editor UI requires the parent nodes' types to be available Metrics editor requires the parent nodes' types Jan 9, 2026
@shangyian shangyian changed the title Metrics editor requires the parent nodes' types Metrics editor requires the parent node type Jan 9, 2026
@shangyian shangyian changed the title Metrics editor requires the parent node type Metrics editor requires the parent node types Jan 9, 2026
@shangyian shangyian added the bug Something isn't working label Jan 9, 2026
@shangyian shangyian marked this pull request as ready for review January 10, 2026 00:03
@shangyian shangyian merged commit f7f6912 into DataJunction:main Jan 10, 2026
17 checks passed
@shangyian shangyian deleted the edit-metrics-ui branch January 10, 2026 00:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

bug Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@shangyian