Skip to content

(#424) Pins coordinate should be null #444

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
oeninghe-dataport wants to merge 3 commits into
base: next
Choose a base branch
from
Open

(#424) Pins coordinate should be null #444

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7d61e05
fix(pins): coordinates are nullable now
oeninghe-dataport Jan 7, 2026
7c522e5
Merge branch 'next' into fix/424-pins-coordinate-should-be-null
dopenguin Jan 9, 2026
1b7aa0c
Merge branch 'next' into fix/424-pins-coordinate-should-be-null
dopenguin Jan 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 15 additions & 10 deletions src/plugins/pins/store.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ import { useCoreStore } from '@/core/stores/export'
export const usePinsStore = defineStore('plugins/pins', () => {
const coreStore = useCoreStore()

const coordinate = ref<Coordinate>([])
const coordinate = ref<Coordinate | null>(null)
const getsDragged = ref(false)

const configuration = computed<
Expand All @@ -49,6 +49,9 @@ export const usePinsStore = defineStore('plugins/pins', () => {
)
)
const latLon = computed(() => {
if (!coordinate.value) {
return null
}
const lonLat = toLonLat(coordinate.value, coreStore.configuration.epsg)
return [lonLat[1], lonLat[0]]
})
Expand Down Expand Up @@ -160,15 +163,17 @@ export const usePinsStore = defineStore('plugins/pins', () => {
feature.getGeometry() as Point
).getCoordinates()

addPin(
!(await isCoordinateInBoundaryLayer(
geometryCoordinates,
coreStore.map,
configuration.value.boundary
))
? coordinate.value
: geometryCoordinates
)
const newCoordinate = !(await isCoordinateInBoundaryLayer(
geometryCoordinates,
coreStore.map,
configuration.value.boundary
))
? coordinate.value
: geometryCoordinates

if (newCoordinate) {
addPin(newCoordinate)
}
})
})
coreStore.map.addInteraction(translate)
Expand Down
Loading