refactor: migrate from constructor based injection to inject function
#496
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
giebelan
commented
Nov 25, 2025
| constructor( | ||
| private appStateService: AppStateService, | ||
| private dataRepoService: DataRepositoryService, | ||
| private logger: Logger, @Inject(LOCALE_ID) private localeId: string, |
Collaborator
Author
There was a problem hiding this comment.
Hier ist tatsächlich ein Fall, wo Konstruktor basierte Injektion problematisch war. localeId wird gar nicht mehr verwendet und kann somit gestrichen werden. Meine IDE hat das zumindest vor dem Refactoring nicht angezeigt. Nach dem Refactoring schon.
Collaborator
|
Kannst du einmal die Konflikte beheben? |
BGruenberg
reviewed
Dec 3, 2025
Comment on lines
+27
to
+34
| private min = inject(new HostAttributeToken('minLength')); | ||
|
|
||
| validator: Function; | ||
|
|
||
| constructor(@Attribute('minLength') private min: number) { | ||
| this.validator = minLengthArrayValidator(min); | ||
| constructor() { | ||
| const min = this.min; | ||
|
|
||
| this.validator = minLengthArrayValidator(Number(min)); |
Collaborator
There was a problem hiding this comment.
Suggested change
| private min = inject(new HostAttributeToken('minLength')); | |
| validator: Function; | |
| constructor(@Attribute('minLength') private min: number) { | |
| this.validator = minLengthArrayValidator(min); | |
| constructor() { | |
| const min = this.min; | |
| this.validator = minLengthArrayValidator(Number(min)); | |
| validator: Function; | |
| constructor() { | |
| const min = inject(new HostAttributeToken('minLength')); | |
| this.validator = minLengthArrayValidator(Number(min)); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Guide und schematic: https://angular.dev/reference/migrations/inject-function
Den müssen wir nicht unbedingt mergen finde ich. Konstruktor Injection funktioniert ja. Die Argumente für und gegen sind auch ein bisschen esoterisch finde ich...
Aber Angular pushed halt schon in die Richtung
inject()und deshalb hätte ich es jetzt einfach gemacht.