Fix $tr from useTranslations when having two parameters with the same…#5
Merged
SchroterQuentin merged 1 commit intodevfrom Apr 1, 2025
Merged
Fix $tr from useTranslations when having two parameters with the same…#5SchroterQuentin merged 1 commit intodevfrom
SchroterQuentin merged 1 commit intodevfrom
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the issue with the translation function when using multiple parameters by replacing the parameter replacement logic from using indexOf to explicitly iterating over the indexes. Additionally, tests have been added to validate that multiple parameters— including duplicate values—are correctly handled.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| tests/Bones.UI.Tests/tests/plugins.test.ts | Added tests to verify $tr with various formatted parameters. |
| src/Bones.UI/composables/useTranslations.ts | Updated parameter replacement to correctly replace placeholders using loop indices. |
SchroterQuentin
approved these changes
Apr 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… value