feat: add unit formatter system with enums and conversion logic by Axlrbs · Pull Request #679 · Dative-GPI/foundation-shared-ui

Axlrbs · 2026-01-27T10:48:02Z

No description provided.

…t registry

…it family enum

Copilot

Pull request overview

This PR introduces a comprehensive unit formatting system that enables automatic conversion and display of physical quantities across multiple unit families including energy, power, mass, distance, pressure, and more.

Changes:

Added unit enums (EnergyUnit, PowerUnit, MassUnit, etc.) with comprehensive coverage of physical quantities
Implemented unit registry with conversion factors, precision settings, and family-based relationships
Created useUnitFormatter composable with formatQuantity, formatQuantityParts, and convert functions
Added extensive test coverage (305 lines) covering family-based scaling, alternative conversions, edge cases, and locale formatting

Reviewed changes

Copilot reviewed 12 out of 12 changed files in this pull request and generated 6 comments.

Show a summary per file

File	Description
src/shared/foundation-shared-domain/enums/units.ts	Defines unit enums (EnergyUnit, PowerUnit, etc.), UnitFamily enum, and UnitPrefix enum for SI prefixes
src/shared/foundation-shared-domain/models/units/unitDetails.ts	Defines TypeScript types for unit definitions including UnitDefinition, UnitConversion, and UnitScaleStep
src/shared/foundation-shared-domain/models/units/unitsRegistry.ts	Implements the unit registry mapping unit strings to their definitions with conversion factors, precision, and families
src/shared/foundation-shared-domain/models/units/index.ts	Exports unit-related models
src/shared/foundation-shared-domain/models/index.ts	Adds units export to main models index
src/shared/foundation-shared-domain/enums/index.ts	Adds units export to main enums index
src/shared/foundation-shared-services/config/units/unitPrefixes.ts	Defines SI prefix configuration for handling unknown units
src/shared/foundation-shared-services/config/units/index.ts	Exports unit configuration
src/shared/foundation-shared-services/config/index.ts	Adds units export to main config index
src/shared/foundation-shared-services/composables/useUnitFormatter.ts	Implements the core formatting logic with family-based conversions, alternative conversions, and SI prefix fallback
src/shared/foundation-shared-services/composables/index.ts	Exports useUnitFormatter composable
tests/shared/units.test.ts	Provides comprehensive test coverage for all formatting scenarios including edge cases and locale-specific formatting

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

src/shared/foundation-shared-domain/models/units/unitDetails.ts

tests/shared/units.test.ts

src/shared/foundation-shared-domain/models/units/unitsRegistry.ts

tests/shared/units.test.ts

src/shared/foundation-shared-domain/enums/units.ts

src/shared/foundation-shared-services/composables/useUnitFormatter.ts

…nd factor attributes

gballigand

Cas d'usages à refléchir :

Passer de °C à F
Passer de la famille Wh à Joules (mais il faut tout de même que ça fasse la mise à l'echelle sur la nouvelle famille)
On veut pouvoir fixer par exemple de m3 et que ça ne descendre jamais en litre mais que ça donne par exemple des milli m2

gballigand · 2026-01-28T14:32:56Z

src/shared/foundation-shared-domain/models/units/unitsRegistry.ts

+import { EnergyUnit, PowerUnit, GasFlowUnit, PressureUnit, TemperatureUnit, SpeedUnit, DistanceUnit, MassUnit, MassFlowUnit, FrequencyUnit, VoltageUnit, CurrentUnit, ResistanceUnit, PercentageUnit, CapacityUnit, SnowProductionUnit, EfficiencyUnit, VolumeUnit, GasVolumeUnit, WaterFlowUnit, UnitFamily } from "@dative-gpi/foundation-shared-domain/enums"
+import type { UnitDefinition } from "./unitDetails"
+
+export const unitRegistry: Record<string, UnitDefinition> = {


si c'est automatique supprimé les cas qui sont générique (Wh par exemple)

gballigand · 2026-01-28T14:33:53Z

src/shared/foundation-shared-domain/models/units/unitsRegistry.ts

+    family: UnitFamily.Volume,
+    factor: 1, // Pivot
+  },
+  [VolumeUnit.m3]: {


le M3 est l'unité SI du litre

- Introduced new functions for finding SI prefixes and parsing units with prefixes. - Enhanced conversion logic to handle conversions within the same family and apply special conversions. - Updated formatQuantity to support target units and unit precision, improving flexibility in formatting. - Added comprehensive tests for various unit conversions, including energy, power, volume, and temperature. - Ensured proper handling of edge cases, including zero, negative values, and unknown units.

…nitSymbol utility function

Copilot

Pull request overview

Copilot reviewed 13 out of 13 changed files in this pull request and generated 7 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-01-29T15:20:04Z

src/shared/foundation-shared-services/composables/useUnitFormatter.ts

+    if (!unitSourceDefinition) {
+      const prefix = findBestSIPrefix(value);
+      const scaledValue = value / prefix.factor;
+      return {
+        value: scaledValue,
+        unit: `${prefix.prefix}${unit}`,
+        symbol: `${prefix.prefix}${unit}`
+      };


The selectBestUnit function ignores the unitPrecision parameter when handling unknown units (lines 94-101). If a source unit is not in the registry, the function applies automatic SI prefix scaling without considering the unitPrecision option. This means the test on line 423-424 may not work as expected - the formatter might return a different prefix than "k" based on the value 123. Consider either documenting this limitation or extending the unknown unit handling to respect unitPrecision when provided.

A réfléchir...

src/shared/foundation-shared-services/composables/useUnitFormatter.ts

tests/shared/units.test.ts

Copilot · 2026-01-29T15:20:05Z

src/shared/foundation-shared-services/composables/useUnitFormatter.ts

+    // Apply special conversions
+    const afterSpecial = applySpecialConversions(value, unit, unitSourceDefinition);
+    if (afterSpecial.unit !== unit) {
+      return selectBestUnit(afterSpecial.value, afterSpecial.unit, unitPrecision);


The recursive call to selectBestUnit on line 138 when a special conversion is applied could lead to infinite recursion if circular special conversions are defined in the unit registry (e.g., unit A converts to B, and B converts back to A under certain thresholds). Consider adding a safeguard such as a maximum recursion depth counter or a visited units set to prevent stack overflow errors.

A réfléchir...

src/shared/foundation-shared-domain/models/units/unitsRegistry.ts

tests/shared/units.test.ts

- Introduced Area unit in UnitFamily and AreaUnit enums. - Updated UnitDefinition to support optional exponent handling. - Enhanced unitFamilies and unitRegistry to include Area unit. - Implemented unit conversion functions to handle exponent-based conversions. - Refactored useUnitFormatter to integrate new conversion logic and thresholds. - Added comprehensive tests for unit conversions, including edge cases for thresholds and exponents.

SchroterQuentin · 2026-02-03T18:34:27Z

J'ai pas eu le temps de te faire un retour mais j'ai regardé le code et c'est trop compliqué. On regarde ça ensemble quand on a un peu de temps.

feat: add unit formatter system with enums and conversion logic

0a19e29

Axlrbs requested review from SchroterQuentin, gballigand and peyronth January 27, 2026 10:48

Axlrbs added 2 commits January 27, 2026 13:57

feat: implement unit formatter system with SI prefixes and update uni…

88bc546

…t registry

feat: enhance unit formatter with family-based conversions and add un…

7c34bce

…it family enum

Axlrbs requested a review from Copilot January 28, 2026 07:44

Copilot started reviewing on behalf of Axlrbs January 28, 2026 07:44 View session

Copilot AI reviewed Jan 28, 2026

View reviewed changes

feat: refine unit definitions and enhance unit registry with family a…

01d6ec3

…nd factor attributes

gballigand reviewed Jan 28, 2026

View reviewed changes

Axlrbs added 3 commits January 29, 2026 08:49

Merge branch 'main' into features/add-unit-formatter-system

1c1f8a6

feat: enhance unit parsing logic in useUnitFormatter and add extractU…

fc948d9

…nitSymbol utility function

Axlrbs requested a review from Copilot January 29, 2026 15:13

Copilot started reviewing on behalf of Axlrbs January 29, 2026 15:14 View session

Copilot AI reviewed Jan 29, 2026

View reviewed changes

Axlrbs added 3 commits January 29, 2026 16:55

fix: copilot review

6820bce

Merge branch 'main' into features/add-unit-formatter-system

d821346

Conversation

Axlrbs commented Jan 27, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

gballigand left a comment

Choose a reason for hiding this comment

Uh oh!

gballigand Jan 28, 2026

Choose a reason for hiding this comment

Uh oh!

gballigand Jan 28, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Jan 29, 2026

Choose a reason for hiding this comment

Uh oh!

Axlrbs Jan 29, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Copilot AI Jan 29, 2026

Choose a reason for hiding this comment

Uh oh!

Axlrbs Jan 29, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

SchroterQuentin commented Feb 3, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants