Skip to content

feat: add useDynamicVueApp composable for dynamic Vue component mounting#683

Open
Axlrbs wants to merge 5 commits intomainfrom
features/add-create-dynamic-vue-app
Open

feat: add useDynamicVueApp composable for dynamic Vue component mounting#683
Axlrbs wants to merge 5 commits intomainfrom
features/add-create-dynamic-vue-app

Conversation

@Axlrbs
Copy link
Contributor

@Axlrbs Axlrbs commented Feb 2, 2026

No description provided.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR introduces a new composable useDynamicVueApp that provides a utility for dynamically mounting Vue components to DOM elements at runtime. The composable generates a unique mount point identifier, manages the lifecycle of a Vue app instance, and returns methods to mount, unmount, and generate HTML for the mount point.

Changes:

  • Added useDynamicVueApp.ts composable with functionality to dynamically create and mount Vue applications
  • Exported the new composable in the composables index file

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 6 comments.

File Description
src/shared/foundation-shared-components/composables/useDynamicVueApp.ts New composable that provides mount/unmount methods and HTML generation for dynamic Vue component mounting
src/shared/foundation-shared-components/composables/index.ts Added export for the new useDynamicVueApp composable

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@SchroterQuentin
Copy link
Member

L'idée est bonne mais l'implémentation manque de petites choses.
J'ai pas compris comment était construit ton app, j'ai l'impression que le if est à l'envers ?
L'injection des options est un peu bancales je trouve, est-ce qu'on pourrait pas utiliser l'app dans laquelle on est tout simplement ?
Les markers on va pas en instancier un seul, donc comment tu gères l'instanciation multiple ?
Je te laisse lire cette petite discussion : https://chatgpt.com/share/69823f4a-39e0-8009-ba7c-72c79272e979

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants