Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This is a release preparation PR for version 1.2.9 that updates the package version and makes configuration adjustments to documentation examples.
- Updates package version from 1.2.8 to 1.2.9 in pyproject.toml
- Removes Python 3.9 support by updating minimum Python requirement to 3.10
- Updates documentation examples with revised context lengths and configuration parameters
Reviewed Changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| pyproject.toml | Version bump to 1.2.9, drops Python 3.9 support, removes commented Python 3.9 wheel reference |
| docs/USAGE.sglang.md | Updates Docker image tags to v1.2.9, revises context length configurations and adds new tool-call-parser parameters |
Comments suppressed due to low confidence (1)
pyproject.toml:74
- [nitpick] The removal of the Python 3.9 wheel reference is consistent with dropping Python 3.9 support, but consider removing all commented wheel references or keeping them for documentation purposes. The current state has inconsistent commenting patterns.
# { url = "https://github.com/Dao-AILab/flash-attention/releases/download/v2.7.4.post1/flash_attn-2.7.4.post1+cu12torch2.6cxx11abiFALSE-cp310-cp310-linux_x86_64.whl", marker = "sys_platform == 'linux' and python_version == '3.10'" },
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Contributor
Author
|
@gmlwns2000 Docker & Pypi published. Please review this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.