fix: resolve V1 test compatibility (Issue #2)#22
Merged
Conversation
The V1 api/ directory was removed during V2 migration. test_api_v2.py (52 tests) covers the V2 API.
No i18n module exists in V2. Issue #4 will create the multi-language module with proper tests.
- Added test_medex_logger.py to required test matrix (39/39 pass) - Removed Legacy Tests job (no legacy test files remain) - Cleaned up extended test ignore list
- Added test_medex_logger.py to required test matrix (39/39 pass) - Removed Legacy Tests job (no legacy test files remain) - Cleaned up extended test ignore list
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix V1 test compatibility
Closes #2
Problem
Three test files used V1-style imports that have been broken since the V2 architecture migration:
test_api.pyfrom api.auth import ...api/directory removedtest_i18n.pyfrom i18n import ...test_medex_logger.pyfrom medex_logger import ...medex_logger.pyworksEngineering Decisions
test_api.py→ Deletedapi/module (auth, main, models, services) no longer existstest_api_v2.py(52 tests, 867 lines) fully covers the V2 APItest_i18n.py→ Deletedsrc/medex/)test_medex_logger.py→ Promoted to required testsmedex_logger.pyis mature, working code with only stdlib depsCI Changes
test_medex_logger.py(39 tests, 0 deps)Local Verification
pytest tests/test_api_v2.py tests/test_detection.py tests/test_differential_diagnosis.py tests/test_medex_logger.py→ 136 passed ✅ruff check src/ tests/→ All checks passed ✅black --check src/ tests/→ All files unchanged ✅Signed: Gonzalo