Skip to content

Set AttrW After Put #292

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
shihab-dls wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Set AttrW After Put #292

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c8f3f84
chore: set sync_setpoint to True after put
shihab-dls Dec 16, 2025
eceea0e
refactor: cast value depending on attrW datatype
shihab-dls Dec 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/fastcs/transports/epics/pva/_pv_handlers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
from p4p.server.asyncio import SharedPV

from fastcs.attributes import Attribute, AttrR, AttrRW, AttrW
from fastcs.datatypes import Table
from fastcs.datatypes import Enum, Table
from fastcs.methods import CommandCallback
from fastcs.tracer import Tracer

Expand Down Expand Up @@ -49,6 +49,10 @@ async def put(self, pv: SharedPV, op: ServerOperation):
tracer.log_event("PV put", topic=self._attr_w, pv=pv, value=cast_value)
await self._attr_w.put(cast_value)
op.done()
if isinstance(self._attr_w.datatype, Enum):
pv.post(cast_to_p4p_value(self._attr_w, cast_value))
else:
pv.post(value)
Copy link
Contributor

@GDYendell GDYendell Dec 17, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What happens on the client if put raises an exception and op.done() is not called? I am wondering if what we are supposed to do when a put fails is call op.done() but not pv.post. Is there any guidance on this? Any thoughts @coretl?

Copy link
Contributor

@coretl coretl Dec 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

op.done(error=msg)
https://epics-base.github.io/p4p/server.html#p4p.server.ServerOperation.done



class CommandPvHandler:
Expand Down