fixes the branch, hopefully fixes downstream problems as well #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
brekk
commented
Nov 16, 2017
tsconfig.json
Outdated
| "target": "es2015" | ||
| }, | ||
| "exclude": [ | ||
| "node_modules/@types/angular-mocks/node_modules/@types" |
Author
There was a problem hiding this comment.
I would like to once again register my general dislike of the current TS ecosystem. I think it means well and is still fixable. But I kinda hate it in its current form.
Author
|
@jacobleesinger also if you could (or I can if you make me an owner of this repo), can you re-hook Circle builds to this repo? Would help give us more confidence that I'm not just randomly breaking things ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.