feat: add healthcheck in deployment k8s manifest#7
Merged
Djaytan merged 1 commit intoDjaytan:mainfrom Jun 6, 2025
Merged
Conversation
Djaytan
reviewed
Jun 6, 2025
Djaytan
requested changes
Jun 6, 2025
Djaytan
requested changes
Jun 6, 2025
Djaytan
requested changes
Jun 6, 2025
Djaytan
requested changes
Jun 6, 2025
jeanbaptisterevel
force-pushed
the
feat/add-healthcheck
branch
3 times, most recently
from
8cb4113 to
36f87ea
Compare
jeanbaptisterevel
force-pushed
the
feat/add-healthcheck
branch
from
aef4bee to
4e4a4cf
Compare
Djaytan
approved these changes
Jun 6, 2025
|
🎉 This PR is included in version 1.1.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a healthcheck in containers
This way, when the server stops for any reason (like eula not accept or any crash), the container will restart by itself
The discussion about the efficiency of a readiness probe VS a startup probe took place in this old PR (in another repository, before the split): Djaytan/docker-papermc-server#212