Add GNU General Public License v3#28
Add GNU General Public License v3#28dark-Invincible wants to merge 1 commit intoDjedAlliance:mainfrom
Conversation
Added the GNU General Public License version 3 to the project.
WalkthroughA GPLv3 license document has been added to the repository. The file contains the complete GNU General Public License version 3 text, including preamble, definitions, terms, conditions, and guidance for applying the license to new programs. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes
Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
License.md (1)
10-10: Markdown heading style inconsistency (optional refactor).The file uses ATX-style headings (
##,###) throughout, but markdownlint expects setext-style headings (underlined with===or---). If your project's markdown style guide prefers setext headings, convert the ATX headings accordingly. This is a stylistic preference and can be deferred or skipped if consistency with the rest of the codebase is not critical.Also applies to: 66-66, 68-68, 105-105, 142-142, 164-164, 178-178, 190-190, 219-219, 299-299, 353-353, 377-377, 387-387, 410-410, 471-471, 482-482, 491-491, 513-513, 523-523, 534-534, 544-544
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
License.md(1 hunks)
🧰 Additional context used
🪛 LanguageTool
License.md
[style] ~19-~19: To make your writing flow more naturally, try moving ‘also’ before the verb.
Context: ...ic License for most of our software; it applies also to any other work released this way by ...
(ALSO_PLACEMENT)
[style] ~173-~173: ‘with respect to’ might be wordy. Consider a shorter alternative.
Context: ...by exercising rights under this License with respect to the covered work, and you disclaim any ...
(EN_WORDINESS_PREMIUM_WITH_RESPECT_TO)
[style] ~253-~253: Consider using only “public” to avoid wordiness.
Context: ...ce of the work are being offered to the general public at no charge under subsection 6d. A se...
(GENERAL_XX)
[style] ~363-~363: ‘prior to’ might be wordy. Consider a shorter alternative.
Context: ... the violation by some reasonable means prior to 60 days after the cessation. Moreover,...
(EN_WORDINESS_PREMIUM_PRIOR_TO)
[style] ~369-~369: ‘prior to’ might be wordy. Consider a shorter alternative.
Context: ...ight holder, and you cure the violation prior to 30 days after your receipt of the notic...
(EN_WORDINESS_PREMIUM_PRIOR_TO)
[style] ~379-~379: Consider a more concise word here.
Context: ...are not required to accept this License in order to receive or run a copy of the Program. A...
(IN_ORDER_TO_PREMIUM)
[style] ~380-~380: To make your writing clearer, consider a shorter, more direct phrase.
Context: ...tion of a covered work occurring solely as a consequence of using peer-to-peer transmission to rece...
(AS_A_CONSEQUENCE_OF)
[style] ~420-~420: To make your writing clearer, consider a shorter, more direct phrase.
Context: ...ude claims that would be infringed only as a consequence of further modification of the contributor...
(AS_A_CONSEQUENCE_OF)
[uncategorized] ~460-~460: If this is a compound adjective that modifies the following noun, use a hyphen.
Context: ...conveying the work, and under which the third party grants, to any of the parties who would...
(EN_COMPOUND_ADJECTIVE_INTERNAL)
[style] ~465-~465: ‘prior to’ might be wordy. Consider a shorter alternative.
Context: ...nt, or that patent license was granted, prior to 28 March 2007. Nothing in this License...
(EN_WORDINESS_PREMIUM_PRIOR_TO)
[style] ~475-~475: ‘So as to’ expresses purpose and is used in formal texts. Consider using “to”.
Context: ...se. If you cannot convey a covered work so as to satisfy simultaneously your obligations...
(SO_AS_TO)
[style] ~583-~583: This phrase is redundant (‘I’ stands for ‘interface’). Use simply “GUI”.
Context: ...am's commands might be different; for a GUI interface, you would use an “about box”. You sho...
(ACRONYM_TAUTOLOGY)
🪛 markdownlint-cli2 (0.18.1)
License.md
10-10: Heading style
Expected: setext; Actual: atx
(MD003, heading-style)
66-66: Heading style
Expected: setext; Actual: atx
(MD003, heading-style)
68-68: Heading style
Expected: setext; Actual: atx
(MD003, heading-style)
105-105: Heading style
Expected: setext; Actual: atx
(MD003, heading-style)
142-142: Heading style
Expected: setext; Actual: atx
(MD003, heading-style)
164-164: Heading style
Expected: setext; Actual: atx
(MD003, heading-style)
178-178: Heading style
Expected: setext; Actual: atx
(MD003, heading-style)
190-190: Heading style
Expected: setext; Actual: atx
(MD003, heading-style)
219-219: Heading style
Expected: setext; Actual: atx
(MD003, heading-style)
299-299: Heading style
Expected: setext; Actual: atx
(MD003, heading-style)
353-353: Heading style
Expected: setext; Actual: atx
(MD003, heading-style)
377-377: Heading style
Expected: setext; Actual: atx
(MD003, heading-style)
387-387: Heading style
Expected: setext; Actual: atx
(MD003, heading-style)
410-410: Heading style
Expected: setext; Actual: atx
(MD003, heading-style)
471-471: Heading style
Expected: setext; Actual: atx
(MD003, heading-style)
482-482: Heading style
Expected: setext; Actual: atx
(MD003, heading-style)
491-491: Heading style
Expected: setext; Actual: atx
(MD003, heading-style)
513-513: Heading style
Expected: setext; Actual: atx
(MD003, heading-style)
523-523: Heading style
Expected: setext; Actual: atx
(MD003, heading-style)
534-534: Heading style
Expected: setext; Actual: atx
(MD003, heading-style)
542-542: Emphasis used instead of a heading
(MD036, no-emphasis-as-heading)
544-544: Heading style
Expected: setext; Actual: atx
(MD003, heading-style)
🔇 Additional comments (2)
License.md (2)
1-595: Verify the purpose and scope of adding the GPLv3 license.This PR adds the full GPLv3 license text as a documentation file. Before merging, clarify:
- Is this intended to be the project's primary license, or a supplementary reference?
- Should a
LICENSEfile (without.mdextension) be created instead, following common convention?- Has the LICENSE file actually been applied to the codebase (via headers, SPDX identifiers, etc.), or is this documentation only?
Adding a license file has repository-wide legal and compliance implications—ensure this change aligns with the project's licensing strategy.
1-595: License content is authentic and correct.The GPLv3 text (version 29 June 2007) matches the official GNU General Public License. The structure, definitions, terms, and guidance sections are all accurate and complete. No modifications to the license text itself are needed.
| ========================== | ||
|
|
||
| _Version 3, 29 June 2007_ | ||
| _Copyright © 2007 Free Software Foundation, Inc. <<http://fsf.org/>>_ |
There was a problem hiding this comment.
Fix HTML entity encoding in URLs.
Lines 5 and 588 contain HTML-encoded angle brackets (< and >) that should be literal < and > characters in a markdown file. This encoding may cause markdown renderers to display the entities literally instead of rendering the URLs correctly.
Apply this diff to fix the encoding:
-_Copyright © 2007 Free Software Foundation, Inc. <<http://fsf.org/>>_
+_Copyright © 2007 Free Software Foundation, Inc. <http://fsf.org/>_And similarly for line 588:
-<<http://www.gnu.org/philosophy/why-not-lgpl.html>>.
+<http://www.gnu.org/philosophy/why-not-lgpl.html>.Also applies to: 588-588
🤖 Prompt for AI Agents
In License.md around lines 5 and 588, the URL angle brackets are HTML-encoded as
< and >; replace those entities with literal '<' and '>' characters so the
URLs are wrapped with <http://fsf.org/> (and the corresponding URL on line 588)
to ensure proper Markdown link rendering; update both occurrences to use literal
angle brackets and save the file.
Added the GNU General Public License version 3 to the project.
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.