Fix stale price data usage in TransactionReview#51
Open
aniket866 wants to merge 1 commit intoDjedAlliance:mainfrom
Open
Fix stale price data usage in TransactionReview#51aniket866 wants to merge 1 commit intoDjedAlliance:mainfrom
aniket866 wants to merge 1 commit intoDjedAlliance:mainfrom
Conversation
📝 WalkthroughWalkthroughA React effect is added to Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
implement this fix: Stale Price Data Usage
Location:
TransactionReview.jsx-Issue: Price data (tradeDataBuySc) is fetched once on component mount. If the user waits 5 minutes before clicking "Pay", the price is outdated.
Impact: Transaction failure (if the contract checks limits) or bad execution price for the user.
Fix: Implement a "Refresh Timer" (e.g., every 15s) or re-fetch quote immediately before signing.
@Zahnentferner
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.