Mock #13
Open
Mock #13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yurii-litvinov
approved these changes
Nov 29, 2017
Collaborator
yurii-litvinov
left a comment
yurii-litvinov
left a comment
There was a problem hiding this comment.
Существенных замечаний нету, так что зачтена
| @@ -0,0 +1,4 @@ | |||
| package ru.mit.spbau.kazakov.exception; | |||
|
|
|||
| public class EmptyStackException extends RuntimeException { | |||
Collaborator
There was a problem hiding this comment.
Вообще, этой штуке тоже нужен комментарий
| import ru.mit.spbau.kazakov.exception.EmptyStackException; | ||
|
|
||
| /** | ||
| * An implementation of stack interface for arithmetic calculator. |
Collaborator
There was a problem hiding this comment.
Неправда, он интерфейс не реализует :)
Кстати, с точки зрения архитектуры --- зря, зависимости от конкретных классов --- это плохо
| * @param value to initialize with | ||
| * @param prev a previous Node | ||
| */ | ||
| Node(T value, Node<T> prev) { |
Collaborator
There was a problem hiding this comment.
Тоже можно было его явно пометить как public или private
|
|
||
| @Test | ||
| public void testIsNumericPlus() { | ||
| assertFalse(ArithmeticUtility.isNumeric("-")); |
Collaborator
There was a problem hiding this comment.
В тесте testIsNumericMinus проверяется +, в тесте testIsNumericPlus проверяется -, к чему бы это?
|
|
||
| PolishNotationCalculator calculator = new PolishNotationCalculator(stack); | ||
| calculator.evaluate(Arrays.asList("1", "2", "%", "5")); | ||
|
|
Collaborator
There was a problem hiding this comment.
На мой вкус лишние пустые строчки не очень
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.