Added workflow to push docker image to ghcr.io#7
Open
VoidChaosCreate wants to merge 6 commits intoDocketGoAI:mainfrom
Open
Added workflow to push docker image to ghcr.io#7VoidChaosCreate wants to merge 6 commits intoDocketGoAI:mainfrom
VoidChaosCreate wants to merge 6 commits intoDocketGoAI:mainfrom
Conversation
DanBrown47
requested changes
Feb 17, 2023
Collaborator
DanBrown47
left a comment
DanBrown47
left a comment
There was a problem hiding this comment.
LGTM ! Need few clarification and add test
| uses: actions/checkout@v3 | ||
|
|
||
| - name: Log in to the Container registry | ||
| uses: docker/login-action@f054a8b539a109f9f41c372932f1ae047eff08c9 |
Collaborator
There was a problem hiding this comment.
What is the hash value after login-action ?
Author
There was a problem hiding this comment.
The hash refers to specific version of docker/login-action. Here, it refers to v2. The hash can be replaced with "docker/login-action@v2" at every instance of the codes. For more reference, you can refer here.
|
|
||
| - name: Extract metadata (tags, labels) for Docker | ||
| id: meta | ||
| uses: docker/metadata-action@98669ae865ea3cffbcbaa878cf57c20bbf1c6c38 |
Collaborator
There was a problem hiding this comment.
Is that hash value needed ?
Author
There was a problem hiding this comment.
The "docker/login-action@f054a8b539a109f9f41c372932f1ae047eff08c9" can be replaced with "docker/login-action@v2"
| IMAGE_NAME: ${{ github.repository }} | ||
|
|
||
| jobs: | ||
| build-and-push-image: |
Collaborator
There was a problem hiding this comment.
Can you add Test, as we have tested
Steps follow
- build
- test
- push to docker
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On push and pull requests in the main branch, the workflow builds the docker image and pushes it to the ghcr.io registry. actor and GITHUB_TOKEN are used for authentication.