Skip to content

Conversation

@google-labs-jules
Copy link
Contributor

Context

This PR introduces the initial setup for End-to-End (E2E) testing using Playwright, fulfilling the "Proactive Improvement" goal of the hardening pass. It establishes the infrastructure to verify main user journeys as requested in TASKS.md.

Changes

  • Installed @playwright/test.
  • Configured playwright.config.ts to run against a local dev server.
  • Added a basic e2e/smoke.test.ts to verify the application loads and displays the correct title.
  • Updated package.json with a test:e2e script.
  • Patched server/migrate.ts to allow skipping the database connection check via SKIP_DB_CHECK=true environment variable. This allows the server to start for smoke testing in environments where a full database is not available (like the current verification sandbox or basic CI steps).
  • Updated vitest.config.ts to exclude e2e tests from the unit test runner.
  • Updated .gitignore to exclude Playwright report artifacts.
  • Updated TASKS.md to reflect progress.

Verification

  • npm run test:e2e: Passed (Verified smoke tests).
  • npm run test: Passed (Verified no regression in unit tests).
  • npm run build: Passed (Verified build stability).

Risk Analysis

  • Low Risk: This change primarily adds testing infrastructure.
  • The modification to server/migrate.ts is guarded by an explicit environment variable (SKIP_DB_CHECK), ensuring it does not affect production or standard development workflows unless opted-in.
  • Rollback: Revert this PR.

Manager's Note

All CI checks green. Do not merge automatically.


PR created automatically by Jules for task 14345369779571088007 started by @Doezer

- Setup Playwright with `playwright.config.ts`
- Add smoke tests in `e2e/smoke.test.ts`
- Allow skipping DB check for smoke tests via env var
- Update CI/Test scripts
@google-labs-jules
Copy link
Contributor Author

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant